Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): tune model/dataset/model not-found info output #1259

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Sep 20, 2022

Description

image
image

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added enhancement ❤️ New feature or request client 🌈 labels Sep 20, 2022
@tianweidut tianweidut added this to the v0.3 milestone Sep 20, 2022
@tianweidut tianweidut self-assigned this Sep 20, 2022
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #1259 (fa7bc3f) into main (a95b09c) will increase coverage by 11.76%.
The diff coverage is 40.00%.

@@              Coverage Diff              @@
##               main    #1259       +/-   ##
=============================================
+ Coverage     73.86%   85.62%   +11.76%     
=============================================
  Files           287       62      -225     
  Lines         13334     7027     -6307     
  Branches        649        0      -649     
=============================================
- Hits           9849     6017     -3832     
+ Misses         3263     1010     -2253     
+ Partials        222        0      -222     
Flag Coverage Δ
controller ?
standalone 85.62% <40.00%> (-0.07%) ⬇️
unittests 85.62% <40.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/dataset/view.py 54.09% <16.66%> (-1.08%) ⬇️
client/starwhale/core/dataset/model.py 72.36% <33.33%> (-0.74%) ⬇️
client/starwhale/base/bundle.py 91.36% <50.00%> (-0.67%) ⬇️
client/starwhale/api/_impl/dataset/loader.py 100.00% <100.00%> (ø)
client/starwhale/api/_impl/model.py 91.61% <100.00%> (+0.10%) ⬆️
client/starwhale/base/view.py 83.75% <0.00%> (-0.21%) ⬇️
...ava/ai/starwhale/mlops/storage/env/StorageEnv.java
...ain/java/ai/starwhale/mlops/api/protocol/Code.java
...ava/ai/starwhale/mlops/common/util/RandomUtil.java
... and 226 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing changed the title WIP enhance(client): tune model/dataset/model not-found info output enhance(client): tune model/dataset/model not-found info output Sep 20, 2022
@tianweidut tianweidut merged commit 778cab1 into star-whale:main Sep 20, 2022
@tianweidut tianweidut deleted the enhance/not-found branch April 17, 2023 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants