Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(controller): tune imagePullPolicy for worker container #1257

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

anda-ren
Copy link
Member

Description

IfNotPresent policy is changed to 'Always'
IfNotPresent policy is not well fitted for images like ghcr.io/star-whale/starwhale:latest-cuda11.4 . The caching semantics of the underlying image provider make even imagePullPolicy: Always efficient, as long as the registry is reliably accessible. Your container runtime can notice that the image layers already exist on the node so that they don't need to be downloaded again.

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added this to the v0.3 milestone Sep 20, 2022
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #1257 (8f9686c) into main (a95b09c) will decrease coverage by 13.04%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1257       +/-   ##
=============================================
- Coverage     73.86%   60.82%   -13.05%     
  Complexity     1209     1209               
=============================================
  Files           287      225       -62     
  Lines         13334     6340     -6994     
  Branches        649      649               
=============================================
- Hits           9849     3856     -5993     
+ Misses         3263     2262     -1001     
  Partials        222      222               
Flag Coverage Δ
controller 60.82% <ø> (ø)
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/utils/fs.py
client/starwhale/core/model/store.py
client/starwhale/api/_impl/data_store.py
client/starwhale/utils/docker.py
client/starwhale/core/job/dag.py
client/starwhale/api/_impl/dataset/loader.py
client/starwhale/api/metric.py
client/starwhale/consts/__init__.py
client/starwhale/base/type.py
client/starwhale/consts/env.py
... and 52 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut changed the title fix: tune imagePullPolicy for worker container enhance(controller): tune imagePullPolicy for worker container Sep 20, 2022
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 016d550 into star-whale:main Sep 20, 2022
@anda-ren anda-ren deleted the tune_imagePullPolicy branch September 20, 2022 07:06
@anda-ren anda-ren linked an issue Sep 20, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

runtime image error
2 participants