Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client):remove base64 encode/decode ppl result #1252

Merged

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Sep 20, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #1252 (11fb7a5) into main (b7a536c) will increase coverage by 11.88%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1252       +/-   ##
=============================================
+ Coverage     73.79%   85.68%   +11.88%     
=============================================
  Files           287       62      -225     
  Lines         13312     6994     -6318     
  Branches        646        0      -646     
=============================================
- Hits           9824     5993     -3831     
+ Misses         3268     1001     -2267     
+ Partials        220        0      -220     
Flag Coverage Δ
controller ?
standalone 85.68% <100.00%> (-0.01%) ⬇️
unittests 85.68% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/model.py 91.51% <100.00%> (-0.11%) ⬇️
...guration/security/JwtAuthenticationEntryPoint.java
.../java/ai/starwhale/mlops/common/util/PageUtil.java
...i/starwhale/mlops/domain/bundle/BundleManager.java
...arwhale/mlops/domain/runtime/RuntimeConvertor.java
...tarwhale/mlops/storage/env/UserStorageAuthEnv.java
.../task/status/watchers/log/TaskLogK8sCollector.java
...ai/starwhale/mlops/domain/job/step/StepHelper.java
...in/java/ai/starwhale/mlops/common/IdConvertor.java
.../ai/starwhale/mlops/domain/project/bo/Project.java
... and 216 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit a95b09c into star-whale:main Sep 20, 2022
@goldenxinxing goldenxinxing deleted the fix/remove_base64_encode_ppl_result branch April 27, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants