Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(controller): refactor storage env related code #1249

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

anda-ren
Copy link
Member

Description

As uploading multipart file to minio is failing with s3 sdk, minio sdk is introduced. Maybe caused by sha256 calcaluation not matching between two sides.
image

As we have 3 type of stroage implementions, a small refactor is needed. With the refafctor being done, when new storage implemention is introduced , modification could be limited within storage-access-layer module

  • add minio sdk
  • refactor storage env related code
  • change the default storage type to minio
  • bind some multipart uploading config to env
  • tune exception processing when multipart uploading fails in StorageAccessServiceS3

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 19, 2022

Codecov Report

Merging #1249 (d1c713f) into main (7b04d0e) will decrease coverage by 9.93%.
The diff coverage is 50.94%.

@@             Coverage Diff              @@
##               main    #1249      +/-   ##
============================================
- Coverage     70.56%   60.62%   -9.94%     
- Complexity     1124     1196      +72     
============================================
  Files           284      225      -59     
  Lines         13092     6316    -6776     
  Branches        637      646       +9     
============================================
- Hits           9238     3829    -5409     
+ Misses         3657     2267    -1390     
- Partials        197      220      +23     
Flag Coverage Δ
controller 60.62% <50.94%> (+2.06%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../starwhale/mlops/domain/swds/SwDatasetService.java 0.00% <ø> (ø)
...e/mlops/domain/swds/converter/SwdsBoConverter.java 0.00% <0.00%> (ø)
...le/mlops/domain/swds/objectstore/DsFileGetter.java 60.86% <ø> (ø)
...in/java/ai/starwhale/mlops/storage/StorageUri.java 50.00% <ø> (ø)
...tarwhale/mlops/storage/env/UserStorageAuthEnv.java 0.00% <0.00%> (ø)
...va/ai/starwhale/mlops/storage/s3/BotoS3Config.java 100.00% <ø> (ø)
...whale/mlops/storage/s3/StorageAccessServiceS3.java 78.30% <0.00%> (-2.08%) ⬇️
...mlops/storage/minio/StorageAccessServiceMinio.java 34.82% <34.82%> (ø)
...s/domain/swds/objectstore/StorageAccessParser.java 77.77% <70.00%> (+29.62%) ⬆️
...ps/storage/env/StorageEnvsPropertiesConverter.java 72.72% <72.72%> (ø)
... and 83 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit b7a536c into star-whale:main Sep 20, 2022
@anda-ren anda-ren deleted the auto_install branch September 20, 2022 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants