Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(console): support getting token for swcli login #1238

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Sep 19, 2022

Description

cc @lijing-susan

trigger url: https://my.foo.bar?token=true

token.mp4

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@jialeicui jialeicui added enhancement ❤️ New feature or request console 🎨 console labels Sep 19, 2022
@jialeicui jialeicui marked this pull request as draft September 19, 2022 08:09
@jialeicui jialeicui marked this pull request as ready for review September 19, 2022 08:47
Copy link
Contributor

@waynelwz waynelwz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waynelwz waynelwz merged commit 6efcba1 into star-whale:main Sep 19, 2022
@jialeicui jialeicui deleted the copy-token branch September 20, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console 🎨 console enhancement ❤️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants