Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): fix copyTo/setBytes function of SwByteBuffer #1232

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

jialeicui
Copy link
Contributor

@jialeicui jialeicui commented Sep 16, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1232 (b8d7c1c) into main (ba0710e) will decrease coverage by 12.36%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1232       +/-   ##
=============================================
- Coverage     70.89%   58.52%   -12.37%     
- Complexity     1124     1125        +1     
=============================================
  Files           284      222       -62     
  Lines         13098     6132     -6966     
  Branches        637      639        +2     
=============================================
- Hits           9286     3589     -5697     
+ Misses         3615     2345     -1270     
- Partials        197      198        +1     
Flag Coverage Δ
controller 58.52% <100.00%> (-0.04%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...a/ai/starwhale/mlops/memory/impl/SwByteBuffer.java 94.33% <100.00%> (+0.22%) ⬆️
...n/java/ai/starwhale/mlops/datastore/DataStore.java 94.15% <0.00%> (-1.12%) ⬇️
...whale/mlops/storage/s3/StorageAccessServiceS3.java 79.61% <0.00%> (-0.77%) ⬇️
client/starwhale/core/dataset/model.py
client/starwhale/base/store.py
client/starwhale/base/tag.py
client/starwhale/mngt/__init__.py
client/starwhale/api/_impl/dataset/loader.py
client/starwhale/api/dataset.py
client/starwhale/utils/http.py
... and 55 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jialeicui jialeicui added bug 🐛 Something isn't working datastore 🐇 labels Sep 16, 2022
@jialeicui jialeicui marked this pull request as ready for review September 16, 2022 10:24
@jialeicui jialeicui changed the title fix(datastore): fix copyTo function of SwByteBuffer fix(datastore): fix copyTo/setBytes function of SwByteBuffer Sep 16, 2022
Copy link
Contributor

@xuchuan xuchuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuchuan xuchuan merged commit 61e1419 into star-whale:main Sep 16, 2022
@jialeicui jialeicui deleted the fix-byte-buffer branch September 16, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working datastore 🐇
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants