Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): datastore table list out of bound error when invoke scan api #1231

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Sep 16, 2022

Description

close: #1228

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the bug 🐛 Something isn't working label Sep 16, 2022
@goldenxinxing goldenxinxing self-assigned this Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1231 (b471905) into main (7e5bd6a) will decrease coverage by 12.77%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##               main    #1231       +/-   ##
=============================================
- Coverage     71.28%   58.51%   -12.78%     
  Complexity     1124     1124               
=============================================
  Files           284      222       -62     
  Lines         13096     6130     -6966     
  Branches        637      638        +1     
=============================================
- Hits           9336     3587     -5749     
+ Misses         3563     2345     -1218     
- Partials        197      198        +1     
Flag Coverage Δ
controller 58.51% <0.00%> (-0.02%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/ai/starwhale/mlops/datastore/DataStore.java 94.15% <0.00%> (-1.12%) ⬇️
client/starwhale/base/view.py
client/starwhale/base/uri.py
client/starwhale/api/_impl/wrapper.py
client/starwhale/utils/load.py
client/starwhale/base/cloud.py
client/starwhale/api/metric.py
client/starwhale/utils/error.py
client/starwhale/core/eval/executor.py
client/starwhale/api/dataset.py
... and 53 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@jialeicui
Copy link
Contributor

Does query API need the same logic?

@goldenxinxing
Copy link
Contributor Author

Does query API need the same logic?

already added this logic in ai.starwhale.mlops.datastore.DataStore#query

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit 5797e4f into star-whale:main Sep 16, 2022
@goldenxinxing goldenxinxing deleted the fix/datastore_scan_api_out_of_bound branch April 27, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluation results problem
2 participants