Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): can not load wal after restart #1223

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

jialeicui
Copy link
Contributor

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #1223 (f52a73a) into main (7384cb8) will decrease coverage by 13.77%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1223       +/-   ##
=============================================
- Coverage     68.87%   55.10%   -13.78%     
  Complexity     1071     1071               
=============================================
  Files           292      230       -62     
  Lines         13109     6165     -6944     
  Branches        636      636               
=============================================
- Hits           9029     3397     -5632     
+ Misses         3895     2583     -1312     
  Partials        185      185               
Flag Coverage Δ
controller 55.10% <100.00%> (ø)
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ai/starwhale/mlops/memory/SwBufferInputStream.java 100.00% <100.00%> (ø)
client/starwhale/core/model/store.py
client/starwhale/core/runtime/model.py
client/starwhale/api/_impl/wrapper.py
client/starwhale/core/model/model.py
client/starwhale/core/instance/model.py
client/starwhale/base/mixin.py
client/starwhale/core/runtime/process.py
client/starwhale/utils/retry.py
client/starwhale/core/eval/model.py
... and 53 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@xuchuan xuchuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuchuan xuchuan merged commit ba0710e into star-whale:main Sep 16, 2022
@jialeicui jialeicui deleted the fix-wal-issue branch September 16, 2022 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working datastore 🐇
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants