Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): show security message in English #1218

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

dreamlandliu
Copy link
Contributor

@dreamlandliu dreamlandliu commented Sep 15, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #1218 (fb85b5b) into main (48d946e) will decrease coverage by 13.41%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1218       +/-   ##
=============================================
- Coverage     68.87%   55.46%   -13.42%     
+ Complexity     1071     1066        -5     
=============================================
  Files           292      222       -70     
  Lines         13109     6114     -6995     
  Branches        636      632        -4     
=============================================
- Hits           9029     3391     -5638     
+ Misses         3895     2539     -1356     
+ Partials        185      184        -1     
Flag Coverage Δ
controller 55.46% <ø> (+0.36%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/ai/starwhale/mlops/storage/fs/BotoS3Config.java 100.00% <0.00%> (ø)
client/starwhale/core/model/model.py
client/starwhale/mngt/__init__.py
client/starwhale/base/uri.py
client/starwhale/consts/env.py
client/starwhale/core/project/model.py
client/starwhale/core/instance/model.py
...starwhale/mlops/configuration/WebSocketConfig.java
client/starwhale/core/model/view.py
client/starwhale/utils/debug.py
... and 61 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit 7b04d0e into star-whale:main Sep 16, 2022
@dreamlandliu dreamlandliu deleted the fix/message_locale_english branch January 6, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working controller 🏘️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants