Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): add UT for K8S related code #1216

Merged
merged 3 commits into from
Sep 16, 2022

Conversation

anda-ren
Copy link
Member

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #1216 (6a402fd) into main (48d946e) will decrease coverage by 12.74%.
The diff coverage is 55.55%.

@@              Coverage Diff              @@
##               main    #1216       +/-   ##
=============================================
- Coverage     68.87%   56.13%   -12.75%     
- Complexity     1071     1089       +18     
=============================================
  Files           292      231       -61     
  Lines         13109     6178     -6931     
  Branches        636      641        +5     
=============================================
- Hits           9029     3468     -5561     
+ Misses         3895     2512     -1383     
- Partials        185      198       +13     
Flag Coverage Δ
controller 56.13% <55.55%> (+1.03%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../starwhale/mlops/schedule/k8s/K8sClientConfig.java 0.00% <0.00%> (ø)
...starwhale/mlops/schedule/k8s/NodeEventHandler.java 78.94% <66.66%> (+78.94%) ⬆️
...ava/ai/starwhale/mlops/schedule/k8s/K8sClient.java 72.41% <100.00%> (+69.02%) ⬆️
client/starwhale/api/job.py
client/starwhale/api/_impl/dataset/builder.py
client/starwhale/utils/log.py
client/starwhale/utils/debug.py
client/starwhale/core/instance/view.py
client/starwhale/base/type.py
client/starwhale/utils/retry.py
... and 58 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@dreamlandliu dreamlandliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dreamlandliu dreamlandliu merged commit 81157ae into star-whale:main Sep 16, 2022
@anda-ren anda-ren deleted the ut_ryd2 branch September 16, 2022 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants