Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example: refactor speech command example #1187

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

tianweidut
Copy link
Member

@tianweidut tianweidut commented Sep 13, 2022

Description

depend on pr: #1177
image

Modules

  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #1187 (7309ddc) into main (d7def78) will increase coverage by 5.22%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #1187      +/-   ##
============================================
+ Coverage     76.02%   81.25%   +5.22%     
============================================
  Files           206       62     -144     
  Lines         10899     6923    -3976     
  Branches        444        0     -444     
============================================
- Hits           8286     5625    -2661     
+ Misses         2463     1298    -1165     
+ Partials        150        0     -150     
Flag Coverage Δ
controller ?
standalone 81.25% <ø> (ø)
unittests 81.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/ai/starwhale/mlops/domain/job/JobType.java
...ai/starwhale/mlops/datastore/ColumnSchemaDesc.java
.../starwhale/mlops/schedule/k8s/JobEventHandler.java
...hale/mlops/domain/bundle/revert/RevertManager.java
...e/mlops/domain/swds/converter/SwdsBoConverter.java
...starwhale/mlops/domain/bundle/BundleException.java
.../java/ai/starwhale/mlops/datastore/WalManager.java
...n/task/status/watchers/TaskWatcherForSchedule.java
...hale/mlops/domain/system/agent/AgentConverter.java
...lops/domain/job/step/status/StepStatusMachine.java
... and 134 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut changed the title WIP example: refactor speech command example example: refactor speech command example Sep 14, 2022
@tianweidut tianweidut marked this pull request as ready for review September 14, 2022 02:27
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tianweidut tianweidut merged commit 7bcb723 into star-whale:main Sep 14, 2022
@tianweidut tianweidut deleted the example/refactor-speech branch September 14, 2022 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants