Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(controller): make controller UT report more accurate #1185

Merged
merged 2 commits into from
Sep 14, 2022

Conversation

anda-ren
Copy link
Member

Description

  • lombok generated code will be ignored by the UT report, such as equals hashCode Getters Setters Builder
  • take ignored classes back to account, such as *Controller *Service

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@codecov
Copy link

codecov bot commented Sep 13, 2022

Codecov Report

Merging #1185 (6047a8a) into main (fbd46ca) will decrease coverage by 22.44%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##               main    #1185       +/-   ##
=============================================
- Coverage     76.02%   53.58%   -22.45%     
- Complexity      915     1036      +121     
=============================================
  Files           206      231       +25     
  Lines         10899     6153     -4746     
  Branches        444      643      +199     
=============================================
- Hits           8286     3297     -4989     
- Misses         2463     2668      +205     
- Partials        150      188       +38     
Flag Coverage Δ
controller 53.58% <ø> (-13.35%) ⬇️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/ai/starwhale/mlops/storage/s3/S3Config.java 0.00% <0.00%> (-75.00%) ⬇️
...in/java/ai/starwhale/mlops/common/OrderParams.java 20.00% <0.00%> (-10.00%) ⬇️
...hale/mlops/schedule/k8s/ResourceOverwriteSpec.java 45.45% <0.00%> (-4.55%) ⬇️
.../ai/starwhale/mlops/storage/fs/FileStorageEnv.java 81.81% <0.00%> (-1.52%) ⬇️
...a/ai/starwhale/mlops/common/util/JwtTokenUtil.java 80.64% <0.00%> (-0.61%) ⬇️
...va/ai/starwhale/mlops/domain/bundle/BundleUrl.java 0.00% <0.00%> (ø)
...i/starwhale/mlops/memory/SwBufferOutputStream.java 100.00% <0.00%> (ø)
...tarwhale/mlops/domain/bundle/BundleVersionUrl.java 0.00% <0.00%> (ø)
...hale/mlops/domain/swds/objectstore/StorageUri.java 100.00% <0.00%> (ø)
...mlops/storage/configuration/StorageProperties.java 0.00% <0.00%> (ø)
... and 180 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@dreamlandliu dreamlandliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dreamlandliu dreamlandliu merged commit 48a08ed into star-whale:main Sep 14, 2022
@anda-ren anda-ren deleted the ut_report_accurate branch September 14, 2022 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants