Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change the field of task table #1173

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Conversation

anda-ren
Copy link
Member

@anda-ren anda-ren commented Sep 9, 2022

Description

#1162

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@anda-ren anda-ren added the chore 🛎️ some tiny change label Sep 9, 2022
@anda-ren anda-ren added this to the v0.3 milestone Sep 9, 2022
@anda-ren anda-ren self-assigned this Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #1173 (f012abf) into main (3f45d76) will decrease coverage by 10.92%.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##               main    #1173       +/-   ##
=============================================
- Coverage     75.69%   64.77%   -10.93%     
+ Complexity      862      846       -16     
=============================================
  Files           205      140       -65     
  Lines         10784     3798     -6986     
  Branches        419      406       -13     
=============================================
- Hits           8163     2460     -5703     
+ Misses         2475     1192     -1283     
  Partials        146      146               
Flag Coverage Δ
controller 64.77% <100.00%> (+0.01%) ⬆️
standalone ?
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ale/mlops/domain/task/converter/TaskConvertor.java 58.82% <100.00%> (+58.82%) ⬆️
.../java/ai/starwhale/mlops/datastore/WalManager.java 74.23% <0.00%> (ø)
client/starwhale/core/runtime/store.py
client/starwhale/core/project/view.py
client/starwhale/core/eval/executor.py
client/starwhale/core/model/store.py
client/starwhale/utils/process.py
client/starwhale/base/uri.py
client/starwhale/utils/debug.py
client/starwhale/base/tag.py
... and 60 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 6dc6f66 into star-whale:main Sep 9, 2022
@anda-ren anda-ren deleted the fix1162 branch October 11, 2022 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🛎️ some tiny change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants