Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(client): add label for container and cancel by label #1172

Merged
merged 2 commits into from
Sep 12, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Sep 9, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the bug 🐛 Something isn't working label Sep 9, 2022
@goldenxinxing goldenxinxing self-assigned this Sep 9, 2022
@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #1172 (3365f0c) into main (e91f8fd) will increase coverage by 7.84%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1172      +/-   ##
============================================
+ Coverage     73.99%   81.84%   +7.84%     
============================================
  Files           205       63     -142     
  Lines         10778     6911    -3867     
  Branches        419        0     -419     
============================================
- Hits           7975     5656    -2319     
+ Misses         2672     1255    -1417     
+ Partials        131        0     -131     
Flag Coverage Δ
controller ?
standalone 81.84% <100.00%> (+<0.01%) ⬆️
unittests 81.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/core/eval/executor.py 91.73% <ø> (ø)
client/starwhale/core/eval/model.py 77.47% <100.00%> (+0.30%) ⬆️
...java/ai/starwhale/mlops/domain/job/JobManager.java
...in/task/status/watchers/TaskWatcherForLogging.java
...hale/mlops/domain/bundle/revert/RevertManager.java
...arwhale/mlops/domain/user/SystemRoleConvertor.java
...tarwhale/mlops/domain/bundle/tag/TagException.java
...i/starwhale/mlops/schedule/k8s/K8sJobTemplate.java
...hale/mlops/domain/swds/objectstore/StorageUri.java
...starwhale/mlops/common/LocalDateTimeConvertor.java
... and 134 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 5a62e1b into star-whale:main Sep 12, 2022
@goldenxinxing goldenxinxing deleted the fix/add_label_for_container branch September 13, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants