Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): mapper name error with Upper case #1151

Merged
merged 1 commit into from
Sep 8, 2022
Merged

fix(controller): mapper name error with Upper case #1151

merged 1 commit into from
Sep 8, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Sep 8, 2022 •
edited
Loading

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing added the bug 🐛 Something isn't working label Sep 8, 2022
@goldenxinxing goldenxinxing self-assigned this Sep 8, 2022
jialeicui
jialeicui approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui merged commit 8a99e2c into star-whale:main Sep 8, 2022
@goldenxinxing goldenxinxing deleted the fix/dataset_mapper_name_error branch September 13, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jialeicui jialeicui jialeicui approved these changes

@xuchuan xuchuan Awaiting requested review from xuchuan

Assignees

@goldenxinxing goldenxinxing

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goldenxinxing @jialeicui