Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(console): prevent extra interceptors in strict mode #1122

Merged
merged 3 commits into from
Sep 5, 2022
Merged

fix(console): prevent extra interceptors in strict mode #1122

merged 3 commits into from
Sep 5, 2022

Conversation

waynelwz
Copy link
Contributor

@waynelwz waynelwz commented Sep 5, 2022

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@waynelwz waynelwz added hotfix 🔥 hotfix bug console 🎨 console labels Sep 5, 2022
@waynelwz waynelwz added this to the v0.3 milestone Sep 5, 2022
jialeicui
jialeicui previously approved these changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@jialeicui jialeicui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jialeicui jialeicui self-requested a review September 5, 2022 08:10
@jialeicui jialeicui merged commit 597f16a into star-whale:main Sep 5, 2022
@jialeicui jialeicui mentioned this pull request Sep 5, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jialeicui jialeicui jialeicui approved these changes

Assignees
No one assigned
Labels
console 🎨 console hotfix 🔥 hotfix bug
Projects
None yet
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@waynelwz @jialeicui