Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(client): add http_retry decorator #1104

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Client

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added enhancement ❤️ New feature or request client 🌈 labels Sep 1, 2022
@tianweidut tianweidut self-assigned this Sep 1, 2022
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #1104 (b17c55d) into main (62275fe) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1104      +/-   ##
==========================================
+ Coverage   72.11%   72.24%   +0.12%     
==========================================
  Files          61       62       +1     
  Lines        6774     6805      +31     
==========================================
+ Hits         4885     4916      +31     
  Misses       1889     1889              
Flag Coverage Δ
standalone 72.24% <100.00%> (+0.12%) ⬆️
unittests 72.24% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
client/starwhale/api/_impl/data_store.py 94.27% <100.00%> (+0.01%) ⬆️
client/starwhale/base/cloud.py 65.74% <100.00%> (+0.64%) ⬆️
client/starwhale/utils/retry.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tianweidut tianweidut force-pushed the enhance/http-retry branch 2 times, most recently from 10b56be to 95f000e Compare September 1, 2022 14:00
@tianweidut tianweidut changed the title WIP enhance(client): add http_retry decorator enhance(client): add http_retry decorator Sep 1, 2022
@tianweidut tianweidut marked this pull request as ready for review September 1, 2022 14:03
@tianweidut tianweidut requested review from xuchuan, goldenxinxing and jialeicui and removed request for xuchuan September 1, 2022 14:04
@tianweidut tianweidut force-pushed the enhance/http-retry branch 2 times, most recently from f200fb6 to 67ba6ae Compare September 1, 2022 14:11
Copy link
Contributor

@goldenxinxing goldenxinxing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@goldenxinxing goldenxinxing merged commit cbd0602 into star-whale:main Sep 2, 2022
@tianweidut tianweidut deleted the enhance/http-retry branch April 16, 2023 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client 🌈 enhancement ❤️ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants