Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(client): dataset copy error when current instance is not local #1091

Merged
merged 1 commit into from
Aug 31, 2022
Merged

fix(client): dataset copy error when current instance is not local #1091

merged 1 commit into from
Aug 31, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Aug 31, 2022 •
edited
Loading

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@goldenxinxing goldenxinxing self-assigned this Aug 31, 2022
@goldenxinxing goldenxinxing added the bug 🐛 Something isn't working label Aug 31, 2022
tianweidut
tianweidut approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@tianweidut tianweidut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tianweidut tianweidut merged commit 1febccf into star-whale:main Aug 31, 2022
@goldenxinxing goldenxinxing deleted the fix/multi_instance_copy_bug branch September 13, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianweidut tianweidut tianweidut approved these changes

Assignees

@goldenxinxing goldenxinxing

Labels
bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goldenxinxing @tianweidut