Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dataset): add default s3 region for s3 link auth #1011

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

tianweidut
Copy link
Member

Description

Modules

  • Python-SDK

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

@tianweidut tianweidut added bug 🐛 Something isn't working dataset🐫 labels Aug 26, 2022
@tianweidut tianweidut added this to the v0.3 milestone Aug 26, 2022
@tianweidut tianweidut self-assigned this Aug 26, 2022
Copy link
Member

@anda-ren anda-ren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anda-ren anda-ren merged commit fc27ae7 into star-whale:main Aug 26, 2022
@tianweidut tianweidut deleted the fix/add-region-env branch April 17, 2023 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working dataset🐫
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants