Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(controller): job list bug #1008

Merged
merged 3 commits into from
Aug 25, 2022
Merged

fix(controller): job list bug #1008

merged 3 commits into from
Aug 25, 2022

Conversation

goldenxinxing
Copy link
Contributor

@goldenxinxing goldenxinxing commented Aug 25, 2022 •
edited
Loading

Description

Modules

  • UI
  • Controller
  • Agent
  • Client
  • Python-SDK
  • Others

Checklist

  • run code format and lint check
  • add unit test
  • add necessary doc

dreamlandliu
dreamlandliu approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@dreamlandliu dreamlandliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dreamlandliu dreamlandliu merged commit 3eef539 into star-whale:main Aug 25, 2022
@goldenxinxing goldenxinxing deleted the fix/job_list_bug branch September 13, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamlandliu dreamlandliu dreamlandliu approved these changes

@anda-ren anda-ren Awaiting requested review from anda-ren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goldenxinxing @dreamlandliu