fix(client): forgot to close the file

star-whale · Jul 11, 2022 · 71779a0 · 71779a0
1 parent ae97c1a
commit 71779a0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/client/starwhale/base/tag.py b/client/starwhale/base/tag.py
@@ -121,6 +121,7 @@ def list(self) -> t.List[str]:
     def get_manifest_by_dir(cls, dir: Path) -> t.Dict[str, t.Any]:
         _mf = dir / DEFAULT_MANIFEST_NAME
         if _mf.exists():
-            return yaml.safe_load(_mf.open()) or {}
+            with open(_mf) as f:
+                return yaml.safe_load(f) or {}
         else:
             return {}
diff --git a/client/starwhale/utils/fs.py b/client/starwhale/utils/fs.py
@@ -17,7 +17,8 @@
 def ensure_file(path: t.Union[str, Path], content: str, mode: int = 0o644) -> None:
     p = Path(path)
     try:
-        _saved = p.open("r").read()
+        with p.open("r") as f:
+            _saved = f.read()
     except IOError as e:
         if e.errno == errno.ENOENT:
             # no such file or directory