add src and style fields to package.json for increased compatibility. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Quick question though... I'm not very familiar with browserify, so bear with me, but should we use minified js file, or is that something that browserify will handle? |
|
I realized I used the minified CSS, but uncompressed JS after I posted it. I prefer unminified assets for development, and then I let my build tool (in my current case, Gulp) do the minification (usually via Uglify). Should I submit a new PR with the uncompressed CSS as well? |
|
Yeah that's fine - would you mind redoing against the 'develop' branch though? Thanks! |
|
sure thing. |
|
moving to develop branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps scripts (such as browserify) find the js and css files.