Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests against task 336990 #45

Open
wants to merge 99 commits into
base: sisyphus-ci
Choose a base branch
from
Open

Conversation

stanislavlevin
Copy link
Owner

stanislavlevin and others added 30 commits December 15, 2023 18:07
This fixes TestIPACommand.test_change_selinuxusermaporder.

TODO: send to upstream
ALT Linux doesn't utilize NIS.
Crypto policy is not supported on ALTLinux.
* added automount direct and indirect maps
* added automount home directory for IPA users
* added mount options check
* added nfs idmapping check

Signed-off-by: Stanislav Levin <slev@altlinux.org>
This test suite takes a long time. First, let's measure the test
duration(limited up to 6 hours).
Install package via apt using query '*package_name' leads to:
"E: Regex compilation error - Invalid preceding regular expression".
The proper regex is '.*package_name', but in this case results in
apt fails to install debuginfo packages for ALT.
IPA client is installed without 'mkhomedir' option by default that
means there will be no user's home directory by default.

`tasks.run_command_as_user` utilizes `su -l USER` under the hood.

Fedora's su is built from util-linux project and it allows missing
working directory:
```console
[root@778019601c21 /]# su -l test
su: warning: cannot change directory to /home/test: No such file or directory
[test@778019601c21 /]$
```

while ALTLinux' su is built from SimplePAMApps
(https://mirrors.edge.kernel.org/pub/linux/libs/pam/pre/applications/)
and it doesn't allow missing working directory:
```console
[root@dc /]# su -l test
/home/test not available; exiting
[root@dc /]#
```
keyboard-interactive doesn't work for ALT out of the box.
This should be removed on implementation of control policy.

See, https://bugzilla.altlinux.org/38977
With `pam_mktemp` a temp directory is `/tmp/.private/$USER`.
So, test user is not allowed to read/write root's temp directory.
The usage of `semanage` util (policycoreutils) should be optional
since not all the distros are SELinux compatible.
ALTLinux doesn't have systemwide crypto policy.
The changing of time affects the host and all of the containers
running on it. So, this test should be skipped in such environments
or should be run at standalone mode.
`test_ssh_key_connection` expects the marker for closing the ssh
session like:
sshd[26903]: pam_unix(sshd:session): session opened for user test-ssh by (uid=0)
sshd[26903]: pam_unix(sshd:session): session closed for user test-ssh
Journald may lose _SYSTEMD_UNIT field for short-lived processes:
https://bugs.freedesktop.org/show_bug.cgi?id=50184

This field is used for message filtering by option '-u'.
More reliable way is using of SYSLOG_IDENTIFIER one.

Related: https://pagure.io/freeipa/issue/8682
…ree space

Azure Pipelines doesn't provide too many disk resources. Usually,
available space is about 19-20%. This makes test_ipa_healthcheck_no_errors
flaky.
…tion

The number of expected tracked certificates is harcoded to 12,
but this depends on kra installation, which either happened or not.
- in case of Azure Pipelines the global DNS is only available
after domain joining on clients.
- provide ALT specific task for postfix
ALT doesn't support system crypto policy yet.
The available free space on Azure's VM is about 20%(time to time),
this makes ipa-healthcheck tests flaky.
`fastlint` build rule was removed in 4.9.11-alt1.
With 4.9.11-alt1 `lint` build rule is disabled by default. This
leads to missing lint dependencies in CI. For example, pylint fails with:
```
************* Module setup_containers
.github/workflows/scripts/setup_containers.py:9: [E0401(import-error), ] Unable to import 'docker')
************* Module ipatests.azure.scripts.setup_containers
ipatests/azure/scripts/setup_containers.py:9: [E0401(import-error), ] Unable to import 'docker')
```
Order of installation/querying `ipa-healthcheck` in
`TestIpaHealthCheckWithoutDNS::test_ipa_dns_systemrecords_check`
test can lead to failures:
- querying the version of `ipa-healthcheck` fails because of
  the missing corresponding package. There is no explicit
  installation of the package before this test, though
  `ipa-healthcheck` may be pulled indirectly or may be pre-installed.

- expected message depends on `ipa-healtchcheck` version and it's
  calculated before updating the package. The assumption will be
  wrong on updating 0.11 -> 0.12 for example.

Related: https://pagure.io/freeipa/issue/9291
Test test_adtrust_install_with_incorrect_admin_password assumes
KCM ccache type, while it can be any one.

sssd-kcm is optional package.

Fixes:
     def test_adtrust_install_with_incorrect_admin_password(self):
         """
         Test to check ipa-adtrust-install with incorrect admin
         password
         """
         password = "wrong_pwd"
         msg = (
             "Must have Kerberos credentials to setup AD trusts on server: "
             "Major (458752): No credentials were supplied, or the credentials "
             "were unavailable or inaccessible, Minor (2529639053): "
             "No Kerberos credentials available (default cache: KCM:)\n"
         )
         self.master.run_command(["kdestroy", "-A"])
         result = self.master.run_command(
             ["ipa-adtrust-install", "-A", "admin", "-a",
              password, "-U"], raiseonerr=False
         )
 >       assert msg in result.stderr_text
 E       AssertionError: assert 'Must have Kerberos credentials to setup AD trusts on server: Major (458752): No credentials were supplied, or the credentials were unavailable or inaccessible, Minor (2529639053): No Kerberos credentials available (default cache: KCM:)\n' in 'Must have Kerberos credentials to setup AD trusts on server: Major (458752): No credentials were supplied, or the credentials were unavailable or inaccessible, Minor (2529639053): No Kerberos credentials available (default cache: FILE:/tmp/krb5cc_0)\n'
[2023-06-07 17:09:45] E        +  where 'Must have Kerberos credentials to setup AD trusts on server: Major (458752): No credentials were supplied, or the credentials were unavailable or inaccessible, Minor (2529639053): No Kerberos credentials available (default cache: FILE:/tmp/krb5cc_0)\n' = <pytest_multihost.transport.SSHCommand object at 0x7fc7b821ce50>.stderr_text
`test_user_connects_smb_share_if_locked_specific_group` utilized
chcon to change file SELinux security context. This leads to error
on non-SELinux machines:
[] RUN ['chcon', '-t', 'samba_share_t', '/freeipa4234']
[] chcon: can't apply partial context to unlabeled file '/freeipa4234'
[] Exit code: 1
[] stderr: chcon: can't apply partial context to unlabeled file '/freeipa4234'
`ipa-adtrust-install` is shipped on `/usr/sbin` in ALTLinux
and `su` don't put it on user's PATH.

Fixes:
[] RUN ['su', '-l', 'ipauser2', '-c', 'ipa-adtrust-install']
[] -bash: ipa-adtrust-install: command not found
[] Exit code: 127
[] stderr: -bash: ipa-adtrust-install: command not found
The available free space on Azure's VM is about 20%(time to time),
this makes ipa-healthcheck tests flaky.
With recent node 18 release in ALTLinux the nodejs package is
provided by 2 packages and apt fails to resolve it.

See https://bugzilla.altlinux.org/47092 for details.
This reverts commit d07fd7b7c4ccf10c65f946ed0cc393d0349ab62b.

https://bugzilla.altlinux.org/47092 has been fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant