PEFT on Named Entity Recognition #1336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jemoka
force-pushed
the
peft-ner
branch
3 times, most recently
from
08d15ca to
0fdd48b
Compare
Jemoka
changed the title
AngledLuffa
reviewed
Feb 21, 2024
AngledLuffa
reviewed
Feb 21, 2024
stanza/models/ner/trainer.py
Outdated
|
|
||
|
|
||
| # IMPORTANT: gradient checkpointing BREAKS peft if applied before | ||
| # 1. Apply PEFT FIRST (looksie! its above this line) |
AngledLuffa
reviewed
Feb 21, 2024
stanza/models/ner/trainer.py
Outdated
| @@ -85,7 +111,10 @@ def __init__(self, args=None, vocab=None, pretrain=None, model_file=None, device | |||
| if pname.split('.')[0] not in exclude: | |||
| p.requires_grad = False | |||
| self.model = self.model.to(device) | |||
| self.optimizer = utils.get_optimizer(self.args['optim'], self.model, self.args['lr'], momentum=self.args['momentum'], bert_learning_rate=self.args.get('bert_learning_rate', 0.0)) | |||
| if not second_optim: | |||
| self.optimizer = utils.get_optimizer(self.args['optim'], self.model, self.args['lr'], momentum=self.args['momentum'], bert_learning_rate=self.args.get('bert_learning_rate', 0.0), is_peft=bool(self.args.get("peft"))) | |||
There was a problem hiding this comment.
these are still using the old peft argument it appears
AngledLuffa
reviewed
Feb 21, 2024
stanza/models/ner/trainer.py
Outdated
| @@ -15,6 +15,9 @@ | |||
| from stanza.models.ner.vocab import MultiVocab | |||
| from stanza.models.common.crf import viterbi_decode | |||
|
|
|||
| from peft import get_peft_model_state_dict, set_peft_model_state_dict | |||
There was a problem hiding this comment.
oh! one last thing. unless / until we've decided to make these required, we should hide these imports in the functions that use them. i can make that change
…t a requirement yet
… note on something we need to do in the bert test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1337 and #1338 (merged)