Enhanced semgrex #1298
Merged
Enhanced semgrex #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enhanced dependencies from UD
Adds a method for adding a networkx graph as a DependencyGraph proto Includes a test that the result on a simple graph is as expected We then read in enhanced graphs, then send that graph to the CoreNLP semgrex rather than the basic dependencies A couple specific changes: When adding a token to a semgrex protobuf, add index for regular words, add index and emptyIndex for empty words Attachs the tokens from a sentence to the networkx graph when building the DependencyGraph proto from a Sentence Currently hard to add a test for this, since it requires some extensive CoreNLP changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to Semgrex to process and print out treebanks with enhanced graphs. There is also an option to use the Semgrex query over the enhanced graph, rather than using the basic dependencies. Needs a new CoreNLP release to be functional