Networkx for enhanced dependencies #1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Installs networkx in setup.py Pass around the Sentence when making Words and Tokens (they are only ever created as part of the Sentence creation) The Words will attach their enhanced deps to the sentence's graph Add a utility method to check if the enhanced dependencies are empty or not Treat empty nodes as tuples in the enhanced dependency graph (those nodes are not kept in the data conversion yet, though...). We store all parents as tuples in the enhanced graph, not just the ones which represent empty nodes. That makes the sorting code easier later on, when retrieving the deps
…dices into their own list The only other use of conll2dict can just ignore the empty words Then we pass the empty words to the Document constructor and attach them to a Sentence Output empty_words as part of the conll or when calling to_dict() Includes a test of the output formats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the networkx library to represent enhanced dependencies when reading in a UD data file
Also, correctly process extra words if
ignore_gappingisFalse. That includes reading them, attaching them as a second list to the sentence, and then outputting them back in the conll or dict formatsThe networkx graph is a little slow, so we lazy initialize it (such as when using the Pipeline, which won't create enhanced dependencies)