Parsing fails on AssertionError when using OpenIE (v3.9.2)

[manzurola]

Happens with the following sentence, under version 3.9.2, only when adding openIE annotator:

It was a long and stern face, but with eyes that twinkled in a kindly way.

stack trace:

java.lang.AssertionError at edu.stanford.nlp.naturalli.Util.cleanTree(Util.java:324) at edu.stanford.nlp.naturalli.OpenIE.annotateSentence(OpenIE.java:463) at edu.stanford.nlp.naturalli.OpenIE.lambda$annotate$2(OpenIE.java:547) at java.base/java.util.ArrayList.forEach(ArrayList.java:1540) at edu.stanford.nlp.naturalli.OpenIE.annotate(OpenIE.java:547) at edu.stanford.nlp.pipeline.AnnotationPipeline.annotate(AnnotationPipeline.java:76) at edu.stanford.nlp.pipeline.StanfordCoreNLP.annotate(StanfordCoreNLP.java:637) at edu.stanford.nlp.pipeline.StanfordCoreNLP.annotate(StanfordCoreNLP.java:629)

to replicate:

        Properties props = new Properties();
        props.setProperty("annotators", "tokenize,ssplit,pos,lemma,ner,depparse,natlog,openie");
        StanfordCoreNLP pipeline = new StanfordCoreNLP(props);

        String text = "It was a long and stern face, but with eyes that twinkled in a kindly way.";

        CoreDocument document = new CoreDocument(text);
        pipeline.annotate(document);

works fine if openie is disabled, with other sentences, or when using https://corenlp.run/ so looks like it's fixed in later versions but I did not verify it locally as I can't upgrade at the moment anyway.

advice much appreciated

[manzurola]

could be related to https://github.com/stanfordnlp/CoreNLP/issues/804

[AngledLuffa]

It doesn't seem to happen in the latest version. Would you let us know if you find an example that crashes the latest version? I'm not sure if it's been fixed or just the graph has changed in a way that no longer triggers the error for this sentence.

[AngledLuffa]

Is there some reason you can't update?

[manzurola]

Thanks John. Updating to v4 was a low priority task for now but we bumped it up, did a quick demo and indeed the error has been resolved in v4. No other errors present for now and I will happily update if otherwise.
Your hard work is much appreciated, thanks again 🤘

[amracel]

I'm hoping this comment goes in, even though the issue is closed. I'm using version 4.3.2 and still having the problem listed. My code is similar to what is shown in the example. Here's the stack trace:

java.lang.AssertionError
	at edu.stanford.nlp.naturalli.Util.cleanTree(Util.java:324)
	at edu.stanford.nlp.naturalli.OpenIE.annotateSentence(OpenIE.java:474)
	at edu.stanford.nlp.naturalli.OpenIE.lambda$annotate$2(OpenIE.java:558)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at edu.stanford.nlp.naturalli.OpenIE.annotate(OpenIE.java:558)
	at edu.stanford.nlp.pipeline.AnnotationPipeline.annotate(AnnotationPipeline.java:76)
	at edu.stanford.nlp.pipeline.StanfordCoreNLP.annotate(StanfordCoreNLP.java:655)
	at mil.threesixtythirdisrw.nlp.openie.classfinder.util.OpenIESeparator.annotateDoc(OpenIESeparator.java:45)
	at mil.threesixtythirdisrw.nlp.openie.classfinder.util.OpenIESeparatorTest.testSubstitutions(OpenIESeparatorTest.java:83)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:64)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:564)
	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)
	at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
	at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
	at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
	at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
	at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
	at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$7(TestMethodTestDescriptor.java:214)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:210)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:135)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:66)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:151)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:41)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:35)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:54)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:107)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:88)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.lambda$execute$0(EngineExecutionOrchestrator.java:54)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.withInterceptedStreams(EngineExecutionOrchestrator.java:67)
	at org.junit.platform.launcher.core.EngineExecutionOrchestrator.execute(EngineExecutionOrchestrator.java:52)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:114)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:95)
	at org.junit.platform.launcher.core.DefaultLauncherSession$DelegatingLauncher.execute(DefaultLauncherSession.java:91)
	at org.junit.platform.launcher.core.SessionPerRequestLauncher.execute(SessionPerRequestLauncher.java:60)
	at org.eclipse.jdt.internal.junit5.runner.JUnit5TestReference.run(JUnit5TestReference.java:98)
	at org.eclipse.jdt.internal.junit.runner.TestExecution.run(TestExecution.java:40)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:529)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.runTests(RemoteTestRunner.java:756)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.run(RemoteTestRunner.java:452)
	at org.eclipse.jdt.internal.junit.runner.RemoteTestRunner.main(RemoteTestRunner.java:210)

The paragraph I sent it was:
Unmanned systems are machines that operate under a “sense,” “think,” “act” paradigm. That is, they are distinguished from regular machines not just by the fact that there is no human inside, but also by the fact that they carry sensors that gather information about the world around them, processors that use that information to make appropriate decisions, and effectors that act to create change in the world around the machine, such as by movement or firing a weapon. They do not merely remove the human from risk, changing our very concept of the role of a warrior, but in so doing reshape many of the foundational concepts of what war itself entails.

[AngledLuffa]

I'm afraid "similar" doesn't narrow it down enough. I did this and it didn't crash. If you can be more specific about how to cause the crash, I'll try to fix it.

import java.util.*;
import edu.stanford.nlp.pipeline.*;

class foo {
  public static void main(String[] args) {
    Properties props = new Properties();
    props.setProperty("annotators", "tokenize,ssplit,pos,lemma,ner,depparse,natlog,openie");
    StanfordCoreNLP pipeline = new StanfordCoreNLP(props);

    String text = "Unmanned systems are machines that operate under a “sense,” “think,” “act” paradigm. That is, they are distinguished from regular machines not just by the fact that there is no human inside, but also by the fact that they carry sensors that gather information about the world around them, processors that use that information to make appropriate decisions, and effectors that act to create change in the world around the machine, such as by movement or firing a weapon. They do not merely remove the human from risk, changing our very concept of the role of a warrior, but in so doing reshape many of the foundational concepts of what war itself entails.";

    CoreDocument document = new CoreDocument(text);
    pipeline.annotate(document);
  }
}

[amracel]

Sorry. Here's my code that calls it:

	public Annotation annotateDoc(String text) {
		Properties props = PropertiesUtils.asProperties("annotators",
				"tokenize,ssplit,pos,lemma,ner,depparse,coref,natlog,openie");
		StanfordCoreNLP pipeline = new StanfordCoreNLP(props);
		Annotation doc = new Annotation(text);
               pipeline.annotate(doc);
               return doc;
     }

I see that you use 'CoreDocument' instead of 'Annotation'. Would that make a difference?

[AngledLuffa]

I'm still not able to trigger it. Are you certain this is version 4.3.2, with the text I just posted in my example? If you run that example, does it cause an error?

[amracel]

OK - what worked was removing the 'ea' flag, as suggested in issue 804. But yes, I am running version 4.3.2.

[AngledLuffa]

That's a pretty crap workaround. However, I can't figure out how to reproduce this issue. What I have done is put a more detailed exception into our dev branch:

106bae1

Are you able to rebuild the source tree including this change and retry the query which is causing you problems? I can also prepare an interim release if that would make it easier to run this. We really should figure out what's causing the error...

[AngledLuffa]

I built a sample distribution to accommodate some other issues as well:

https://nlp.stanford.edu/software/stanford-corenlp-4.3.2b.zip

Would you try the text that was causing you problems, then report the error if it produces an error? I'd like to actually fix this rather than just ignore it

[amracel]

I took your jar and substituted it for the one I was using in my code and saw no difference when I readded the 'ea' flags. So, I tried to minimize the differences by adding the 'ea' flags to the corenlp.sh file:

#java -mx5g -cp "$scriptdir/*" edu.stanford.nlp.pipeline.StanfordCoreNLP $*
java -ea -mx5g -cp "$scriptdir/*" edu.stanford.nlp.pipeline.StanfordCoreNLP $*

I put my text into the input.txt file.

I then called it with the annotators I was trying to use:

./corenlp.sh -annotators tokenize,ssplit,pos,lemma,ner,depparse,coref,natlog,openie -file input.txt

I still got the same error.