Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for reranker and other utilities #258

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Adding support for reranker and other utilities #258

wants to merge 7 commits into from

Conversation

krypticmouse
Copy link

@krypticmouse krypticmouse commented Sep 26, 2023 •
edited
Loading

In this PR, I'm adding support for reranker and other additional utilities, more precisely:-

  • Adding support for reranker class
  • Bug fix that made all the workers get the same triples
  • Adding evaluation scripts for trec and stack_overflow
  • Adding support to load jsonl files in query and collection
  • Adding support to combine description/body with query to process SO, reddit etc. like queries
  • Add triple shuffling in the code itself
  • Adding BGE biencoder/reranker scorer support
  • Adding base support for HF scorer

okhat
okhat reviewed Sep 29, 2023
View reviewed changes
README.md
@@ -177,6 +177,38 @@ if __name__=='__main__':
print(f"Saved checkpoint to {checkpoint_path}...")
```

## Reranking
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really cool, Herumb!

okhat
okhat reviewed Sep 29, 2023
View reviewed changes
colbert/distillation/hf_scorers/__init__.py Outdated
@@ -0,0 +1,2 @@
from .bge_reranker import BGERerankerScorer
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this here?

Copy link
Author

@krypticmouse krypticmouse Sep 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean the init file or bge models and hf scorers?

No in both. We can remove init file and we can remove hf scorers as whole too given they don't play any role as of now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okhat okhat Awaiting requested review from okhat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krypticmouse @okhat