Integrate Psychometric-Based Question Validity Tools into HELM (Issue #3645)#3669
Open
yuhengtu wants to merge 4 commits intostanford-crfm:mainfrom
Open
Integrate Psychometric-Based Question Validity Tools into HELM (Issue #3645)#3669yuhengtu wants to merge 4 commits intostanford-crfm:mainfrom
yuhengtu wants to merge 4 commits intostanford-crfm:mainfrom
Conversation
added 2 commits
June 13, 2025 05:20
yifanmai
requested changes
Jun 19, 2025
yifanmai
approved these changes
Jun 21, 2025
yifanmai
requested changes
Jun 23, 2025
| help="EXPERIMENTAL: Full class name of the Summarizer class to use. If unset, uses the default Summarizer.", | ||
| ) | ||
| parser.add_argument( | ||
| "--validity-check", |
Collaborator
There was a problem hiding this comment.
I would prefer this to be --psychometric-validity-check because "validity" is a vague concept (it could be data completeness validation, or data schema validation, or other kinds of validation).
| def write_run_display_json(self, skip_completed: bool) -> None: | ||
| def process(run: Run) -> None: | ||
| write_run_display_json(run.run_path, run.run_spec, self.schema, skip_completed) | ||
| write_run_display_json(run.run_path, run.run_spec, self.schema, self.validity_check, skip_completed) |
Collaborator
There was a problem hiding this comment.
self.validity_check should be the last argument.
| verbose: bool, | ||
| num_threads: int, | ||
| allow_unknown_models: bool, | ||
| validity_check: bool, |
Collaborator
There was a problem hiding this comment.
Change this to psychometrics_validity_check or something that identifies the paper.
Also, set the default value to False to fix these errors:
src/helm/benchmark/presentation/torr_robustness_summarizer.py:36: error: Missing positional argument "validity_check" in call to "__init__" of "Summarizer" [call-arg]
src/helm/benchmark/presentation/test_summarize.py:13: error: Missing positional argument "validity_check" in call to "Summarizer" [call-arg]
src/helm/benchmark/presentation/test_summarize.py:31: error: Missing positional argument "validity_check" in call to "Summarizer" [call-arg]
| @htrack(None) | ||
| def write_run_display_json(run_path: str, run_spec: RunSpec, schema: Schema, skip_completed: bool) -> None: | ||
| def write_run_display_json( | ||
| run_path: str, run_spec: RunSpec, schema: Schema, skip_completed: bool, validity_check: bool = False |
Collaborator
There was a problem hiding this comment.
Change validity_check to psychometrics_validity_check or something that identifies the paper.
Collaborator
|
This fixes #3645. |
Collaborator
|
This pull request is still causing the type checker to fail. If you'd like to merge, please resolve the type checking issues and update this pull request. |
Collaborator
|
Hi, it's been a month since the last update; are you still working on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add a new bool argument --validity-check to helm-summarize. If it is activated, we load the four pre-calculated validity metrics values from HuggingFace and write them into the display_prediction.json. In this way, we achieve the goal of displaying the validity metrics values on the HELM website. The script to calculate those four validity metrics is in
scripts/validity_check.py.