Skip to content

Conversation

yifanmai
Copy link
Collaborator

Gold commodity news is a classification benchmark based on a dataset of human-annotated gold commodity news headlines (Sinha & Khandait, 2019).

@yifanmai
Copy link
Collaborator Author

Hi @ryokawajp, please review this pull request.

By approving, you acknowledge that:

  • You will be listed as a co-author of the merge commit
  • You agree to license your work under Apache 2.0

@yifanmai yifanmai requested a review from ryokawajp October 17, 2024 03:18
Copy link
Collaborator

@ryokawajp ryokawajp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for confirmation, this scenario "gold_commodity_news" corresponds to "news_headline" in the original source code, right?

@yifanmai
Copy link
Collaborator Author

Yes, this corresponds to news_headline in #3064. This dataset doesn't seem to have a canonical name in the literature, so I would prefer to pick a name that is less ambiguous.

@yifanmai yifanmai requested a review from ryokawajp October 17, 2024 17:44
@mtake mtake self-requested a review October 21, 2024 06:45
Copy link
Collaborator

@mtake mtake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Collaborator

@ryokawajp ryokawajp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally.
news_headline is renamed to gold_commodity_news, and the values of category option is changed to a style like price_or_not from Price or Not. I think these changes are reasonable.

I am not sure about test_ewok_scenario.py.

LGTM.

@yifanmai yifanmai force-pushed the yifanmai/fix-gold-commodity-news branch from 37c0439 to b69bf75 Compare October 22, 2024 16:47
@yifanmai
Copy link
Collaborator Author

Resolved the merge conflict - it was required to get an existing failing test to pass, but this has since been resolved by #3069.

@yifanmai yifanmai merged commit 364be45 into main Oct 22, 2024
12 checks passed
@yifanmai yifanmai deleted the yifanmai/fix-gold-commodity-news branch October 22, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants