Skip to content

Conversation

subhaviv
Copy link
Contributor

Addressed comments from the PR #2980 .

@yifanmai
Copy link
Collaborator

yifanmai commented Oct 1, 2024

Thanks for the revision; this looks like the right idea overall.

@subhaviv subhaviv requested a review from yifanmai October 9, 2024 22:32
@yifanmai
Copy link
Collaborator

Please fix: src/helm/clients/bedrock_client.py:27:119: W291 trailing whitespace

@subhaviv subhaviv requested a review from yifanmai October 10, 2024 04:37
@yifanmai yifanmai merged commit 572a1bb into stanford-crfm:main Oct 10, 2024
6 checks passed
@yifanmai
Copy link
Collaborator

Thanks for your help with getting this merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants