Skip to content

Conversation

rbitr
Copy link
Contributor

@rbitr rbitr commented Apr 24, 2024

Blue and Red channels were switched, img_rgba is in rgb order but blue is being pulled from channel 0, red from channel 2. This PR swaps them to the correct channels.

@yifanmai yifanmai requested a review from teetone April 24, 2024 15:54
@yifanmai
Copy link
Collaborator

Thanks @rbitr for catching this!

@teetone could you take a look?

@yifanmai
Copy link
Collaborator

yifanmai commented May 8, 2024

Ping @teetone

@yifanmai
Copy link
Collaborator

Since @teetone hasn't responded, I'll merge this as it looks like a correct fix. Thanks @rbitr!

@yifanmai yifanmai merged commit 83e45f3 into stanford-crfm:main Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants