fix: unsubscribe streamItems on deinit (#453)

standardnotes · Aug 25, 2020 · b1cde83 · b1cde83
1 parent da78399
commit b1cde83
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/app/assets/javascripts/services/preferencesManager.ts b/app/assets/javascripts/services/preferencesManager.ts
@@ -13,20 +13,25 @@ export class PreferencesManager extends ApplicationService {
 
   private userPreferences!: SNUserPrefs
   private loadingPrefs = false;
+  private unubscribeStreamItems?: () => void;
 
   /** @override */
   async onAppLaunch() {
     super.onAppLaunch();
     this.reloadSingleton();
     this.streamPreferences();
   }
+
+  deinit() {
+    this.unubscribeStreamItems && this.unubscribeStreamItems();
+  }
 
   get webApplication() {
     return this.application as WebApplication;
   }
 
   streamPreferences() {
-    this.application!.streamItems(
+    this.unubscribeStreamItems = this.application!.streamItems(
       ContentType.UserPrefs,
       () => {
         this.reloadSingleton();