fix: correctly set/change passcode

standardnotes · Aug 26, 2020 · a63bfd8 · a63bfd8
1 parent 696f34b
commit a63bfd8
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 18 deletions.
diff --git a/app/assets/javascripts/directives/views/accountMenu.ts b/app/assets/javascripts/directives/views/accountMenu.ts
@@ -17,7 +17,8 @@ import {
   STRING_INVALID_IMPORT_FILE,
   STRING_GENERATING_LOGIN_KEYS,
   STRING_GENERATING_REGISTER_KEYS,
-  StringImportError
+  StringImportError,
+  STRING_CONFIRM_APP_QUIT_DURING_PASSCODE_CHANGE
 } from '@/strings';
 import { SyncOpStatus } from 'snjs/dist/@types/services/sync/sync_op_status';
 import { PasswordWizardType } from '@/types';
@@ -52,15 +53,19 @@ type FormData = {
 }
 
 type AccountMenuState = {
-  formData: Partial<FormData>
-  appVersion: string
-  passcodeAutoLockOptions: any
-  user: any
-  mutable: any
-  importData: any
+  formData: Partial<FormData>;
+  appVersion: string;
+  passcodeAutoLockOptions: any;
+  user: any;
+  mutable: any;
+  importData: any;
+  encryptionStatusString: string;
+  server: string;
+  encryptionEnabled: boolean;
+  selectedAutoLockInterval: any;
 }
 
-class AccountMenuCtrl extends PureViewCtrl {
+class AccountMenuCtrl extends PureViewCtrl<{}, AccountMenuState> {
 
   public appVersion: string
   private syncStatus?: SyncOpStatus
@@ -117,15 +122,12 @@ class AccountMenuCtrl extends PureViewCtrl {
 
   $onInit() {
     super.$onInit();
-    this.initProps({
-      closeFunction: this.closeFunction
-    });
     this.syncStatus = this.application!.getSyncStatus();
   }
 
   close() {
     this.$timeout(() => {
-      this.props.closeFunction();
+      this.closeFunction?.();
     });
   }
 
@@ -503,24 +505,31 @@ class AccountMenuCtrl extends PureViewCtrl {
     });
   }
 
-  submitPasscodeForm() {
+  async submitPasscodeForm() {
     const passcode = this.getState().formData.passcode!;
     if (passcode !== this.getState().formData.confirmPasscode!) {
       this.application!.alertService!.alert(
         STRING_NON_MATCHING_PASSCODES
       );
       return;
     }
-    (this.getState().formData.changingPasscode
-      ? this.application!.changePasscode(passcode)
-      : this.application!.setPasscode(passcode)
-    ).then(() => {
+
+    const onBeforeUnload = window.onbeforeunload;
+    try {
+      window.onbeforeunload = () => STRING_CONFIRM_APP_QUIT_DURING_PASSCODE_CHANGE;
+      if (this.application!.hasPasscode()) {
+        await this.application!.changePasscode(passcode);
+      } else {
+        await this.application!.setPasscode(passcode);
+      }
       this.setFormDataState({
         passcode: undefined,
         confirmPasscode: undefined,
         showPasscodeForm: false
       });
-    });
+    } finally {
+      window.onbeforeunload = onBeforeUnload;
+    }
   }
 
   async changePasscodePressed() {

diff --git a/app/assets/javascripts/strings.ts b/app/assets/javascripts/strings.ts
@@ -58,3 +58,7 @@ export const STRING_FAILED_PASSWORD_CHANGE = "There was an error re-encrypting y
 export const STRING_CONFIRM_APP_QUIT_DURING_UPGRADE =
   "The encryption upgrade is in progress. You may lose data if you quit the app. " +
   "Are you sure you want to quit?"
+
+export const STRING_CONFIRM_APP_QUIT_DURING_PASSCODE_CHANGE =
+  "A passcode change is in progress. You may lose data if you quit the app. " +
+  "Are you sure you want to quit?"