fix: reorganize action to prevent deploying when tsc fails

standardnotes · Oct 7, 2020 · 7f4bcde · 7f4bcde
1 parent 2f720d3
commit 7f4bcde
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 5 deletions.
diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml
@@ -5,10 +5,29 @@ on:
     branches: [ develop ]
 
 jobs:
+
+  tsc:
+
+    name: Check types
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Typescript
+        run: npm run tsc
+
   deploy:
 
     runs-on: ubuntu-latest
 
+    needs: tsc
+
     steps:
     - uses: actions/checkout@v2
 

diff --git a/.github/workflows/tsc.yml → .github/workflows/pr.yml b/.github/workflows/tsc.yml → .github/workflows/pr.yml
@@ -1,10 +1,6 @@
-name: Typescript check
+name: Check pull request
 
 on:
-  push:
-    branches:
-      - develop
-      - master
   pull_request:
     branches:
       - develop