feat: display folders even without the premium (#826)

standardnotes · Jan 26, 2022 · 7726b12 · 7726b12
1 parent 86b38e1
commit 7726b12
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 12 deletions.
diff --git a/app/assets/javascripts/components/Tags/RootTagDropZone.tsx b/app/assets/javascripts/components/Tags/RootTagDropZone.tsx
@@ -18,7 +18,6 @@ export const RootTagDropZone: React.FC<Props> = observer(
   ({ tagsState, featuresState }) => {
     const premiumModal = usePremiumModal();
     const isNativeFoldersEnabled = featuresState.enableNativeFoldersFeature;
-    const hasFolders = featuresState.hasFolders;
 
     const [{ isOver, canDrop }, dropRef] = useDrop<DropItem, void, DropProps>(
       () => ({
@@ -27,22 +26,17 @@ export const RootTagDropZone: React.FC<Props> = observer(
           return true;
         },
         drop: (item) => {
-          if (!hasFolders) {
-            premiumModal.activate(TAG_FOLDERS_FEATURE_NAME);
-            return;
-          }
-
           tagsState.assignParent(item.uuid, undefined);
         },
         collect: (monitor) => ({
           isOver: !!monitor.isOver(),
           canDrop: !!monitor.canDrop(),
         }),
       }),
-      [tagsState, hasFolders, premiumModal]
+      [tagsState, premiumModal]
     );
 
-    if (!isNativeFoldersEnabled || !hasFolders) {
+    if (!isNativeFoldersEnabled) {
       return null;
     }
 

diff --git a/app/assets/javascripts/components/Tags/TagsListItem.tsx b/app/assets/javascripts/components/Tags/TagsListItem.tsx
@@ -120,7 +120,7 @@ export const TagsListItem: FunctionComponent<Props> = observer(
           isDragging: !!monitor.isDragging(),
         }),
       }),
-      [tag, hasFolders]
+      [tag, isNativeFoldersEnabled]
     );
 
     const [{ isOver, canDrop }, dropRef] = useDrop<DropItem, void, DropProps>(
@@ -160,7 +160,7 @@ export const TagsListItem: FunctionComponent<Props> = observer(
         >
           {!tag.errorDecrypting ? (
             <div className="tag-info" title={title} ref={dropRef}>
-              {hasFolders && isNativeFoldersEnabled && hasAtLeastOneFolder && (
+              {isNativeFoldersEnabled && hasAtLeastOneFolder && (
                 <div
                   className={`tag-fold ${showChildren ? 'opened' : 'closed'}`}
                   onClick={hasChildren ? toggleChildren : undefined}

diff --git a/app/assets/javascripts/ui_models/app_state/tags_state.ts b/app/assets/javascripts/ui_models/app_state/tags_state.ts
@@ -172,7 +172,7 @@ export class TagsState {
   }
 
   getChildren(tag: SNTag): SNTag[] {
-    if (!this.features.hasFolders) {
+    if (!this.features.enableNativeFoldersFeature) {
       return [];
     }
 
@@ -230,7 +230,7 @@ export class TagsState {
   }
 
   get rootTags(): SNTag[] {
-    if (!this.features.hasFolders) {
+    if (!this.features.enableNativeFoldersFeature) {
       return this.tags;
     }