📝 Responsive Image URLs in TenantAwareUrlGenerator to be Tenant-Aware #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with the
TenantAwareUrlGeneratorwhere the URLs in thesrcsetattribute of responsive images were not tenant-aware, even though thesrcURL was correctly tenant-aware.Problem
When fetching the HTML for a media image using the following code:
The generated
<img>tag had the correct tenant-awaresrcattribute, but thesrcsetattribute URLs were not tenant-aware.Cause
The issue was traced to the
getResponsiveImagesDirectoryUrlmethod in theDefaultUrlGenerator, which was responsible for generating the URLs for responsive images.Solution
To fix this, I have overridden the
getResponsiveImagesDirectoryUrlmethod in theTenantAwareUrlGeneratorto ensure that the URLs for responsive images are also tenant-aware.Changes
getResponsiveImagesDirectoryUrlmethod override inTenantAwareUrlGeneratorto generate tenant-aware URLs for responsive images.This change ensures consistency in URL generation for both
srcandsrcsetattributes, preventing potential issues where non-tenant-aware URLs might lead to incorrect media being served.Please review the changes and let me know if you have any concerns. Thank you!