Change default RNG to boost::mixmax #3264
Merged
Conversation
Member
Author
|
This caused a couple models to change results in the CmdStan Performance Tests:
I don't know enough about the history of the project and how these models and settings were picked, but so far I've yet to encounter them flagging something that wasn't a false alarm. |
Collaborator
|
Your results match up better actually than the current tests so idt this is an issue gen_gp_data is a weird one to fail but idt thats an issue |
09a7d48 to
ebd4a5c
Compare
ebd4a5c to
3b75dc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
./runTests.py src/test/unitmake cpplintSummary
Closes #3256. This switches the pRNG used by default in the services and tests to be
boost::mixmax, as recommended by the boost maintainers: boostorg/random#92Intended Effect
Resolve both #3167 and stan-dev/cmdstan#1241, avoid other issues with RNG quality.
How to Verify
Side Effects
Seeds used in previous versions will have different meanings from this version on. We should note this in the release notes.
Additionally, by changing the type alias of
rng_tintroduced in #3263, this PR changes the ABI of the model base, so code which calls it directly will need to be aware. This is most obviously relevant for things which use the standalone-functions feature of stanc like cmdstanr and rstan, I believe. @andrjohnsDocumentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: