Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/2346 standalone functions for rstan #2347

Merged
merged 4 commits into from
Jul 7, 2017

Conversation

martinmodrak
Copy link
Contributor

@martinmodrak martinmodrak commented Jul 4, 2017

Submisison Checklist

  • Run unit tests: ./runTests.py src/test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary

With respect to #2346 - fix problems in standalone function compilation that block integration with RStan.
As a part of this effort, added a new integration test that checks that all src/test/test-models/good-standalone-functions/*.stanfuncs files succesfully compile.

Intended Effect

RCpp export only for non-templated functions, removed using of lgamma.

How to Verify

Test with RStan :-) For the lgamma, a new test checking whether lgamma compiles in a standalone func has been added.

Side Effects

Hopefully none.

Documentation

N/A

Reviewer Suggestions

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Martin Černý / Institute of Microbiology of the Czech Academy of Sciences

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@mitzimorris mitzimorris merged commit 133884f into develop Jul 7, 2017
@mitzimorris mitzimorris deleted the bugfix/2346-standalone-functions-for-rstan branch July 7, 2017 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants