Bugfix/2346 standalone functions for rstan #2347
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submisison Checklist
./runTests.py src/test/unit
make cpplint
Summary
With respect to #2346 - fix problems in standalone function compilation that block integration with RStan.
As a part of this effort, added a new integration test that checks that all
src/test/test-models/good-standalone-functions/*.stanfuncs
files succesfully compile.Intended Effect
RCpp export only for non-templated functions, removed using of lgamma.
How to Verify
Test with RStan :-) For the lgamma, a new test checking whether lgamma compiles in a standalone func has been added.
Side Effects
Hopefully none.
Documentation
N/A
Reviewer Suggestions
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Martin Černý / Institute of Microbiology of the Czech Academy of Sciences
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: