-
-
Notifications
You must be signed in to change notification settings - Fork 198
Feature/issue 2966 add 7 parameter ddm cdf and ccdf #3042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Feature/issue 2966 add 7 parameter ddm cdf and ccdf #3042
Conversation
…-7-parameter-DDM-CDF-and-CCDF merge PDF branch
merge develop with wiener_lpdf
|
Just chiming in to add a reminder that we discussed naming these functions something other than |
@WardBrian, @bob-carpenter |
That would be fine. We could also introduce a new suffix like |
|
@bob-carpenter How shall we continue? Do you want to go through my questions or through your comments and say which one has to be worked on again? I think that the tests should finish successfully tomorrow. If not, I will have another look into the error messages during the next days. What is still missing is the renaming of the |
|
Thanks. I'll take a look at the questions and we can proceed in parallel. I'm guessing a lot of them will just be due to my misunderstanding. |
|
@bob-carpenter, there is an error message in the continuous-integration test that I do not understand. Do you have a hint what this message means and where it could come from? |
|
thanks so much for addressing my bajillion requests. i am on vacation and
should be able to get to this a week from today. sorry for the delay. you
could try asking @SteveBronder about error msgs.
…On Wed, Nov 5, 2025 at 9:28 AM Franzi2114 ***@***.***> wrote:
*Franzi2114* left a comment (stan-dev/math#3042)
<#3042 (comment)>
@bob-carpenter <https://github.com/bob-carpenter>, there is an error
message in the continuous-integration test that I do not understand. Do you
have a hint what this message means and where it could come from?
—
Reply to this email directly, view it on GitHub
<#3042 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAZ2D7YY3T357OZ5P24AEL333GYK7AVCNFSM6AAAAABFOYZOX6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIOBZHEYTGMRVGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Summary
With this PR the CDF and the CCDF of the 7-parameter diffuion model are added.
See issue #2966
Relates to issue #2822
Tests
We implemented analogous tests as for the PDF
Side Effects
no
Release notes
CDF and CCDF for the 7-parameter diffusion model. Allows modeling truncated and censored data.
Checklist
Copyright holder: Franziska Henrich, Christoph Klauer
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit)make test-headers)make test-math-dependencies)make doxygen)make cpplint)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested