Conversation
Member
|
the method seems sound. |
Member
Author
|
I just ran them locally. They don't use all the models here (really only the ones in |
mitzimorris
approved these changes
Feb 8, 2024
Member
mitzimorris
left a comment
mitzimorris
left a comment
There was a problem hiding this comment.
the method is sound and has been tested locally - good enough for me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was done using
cmdstanr::write_stan_json(rstan::read_rdump(file_R), file_json). The primary goal is to allow us to use these files in the cmdstan performance tests to avoid warnings about RDump, but they also serve as paired examples of the two data formats.