Conversation
Effectively reverts the breaking changes in #681 temporarily
Codecov Report
@@ Coverage Diff @@
## develop #691 +/- ##
===========================================
+ Coverage 79.61% 79.78% +0.17%
===========================================
Files 50 75 +25
Lines 7590 11439 +3849
===========================================
+ Hits 6043 9127 +3084
- Misses 1547 2312 +765 see 35 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2 tasks
2 tasks
Member
Author
|
@mitzimorris I think we should try to do 1.2.0 early next week at this point |
Member
|
do we have a docs example for Pathfinder? I could do this today. |
Member
Author
|
No, a new example notebook would be great! |
This was referenced Sep 22, 2023
This reverts commit 3e7bb8a.
Member
Author
|
@mitzimorris do you have time to review this week? It would be great to release 1.2 with Pathfinder included |
mitzimorris
approved these changes
Oct 2, 2023
Member
mitzimorris
left a comment
There was a problem hiding this comment.
LGTM! thanks for the cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
See #690. This is PR is assuming we go down the "issue as many warnings as possible for a version" branch before releasing a 2.0
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: