Allow git:TAG as a version in install_cmdstan#679
Merged
Conversation
mitzimorris
approved these changes
Jul 21, 2023
Member
mitzimorris
left a comment
There was a problem hiding this comment.
LGTM and runs on my machine!
Codecov Report
@@ Coverage Diff @@
## develop #679 +/- ##
===========================================
- Coverage 81.01% 80.79% -0.22%
===========================================
Files 69 69
Lines 10677 10734 +57
===========================================
+ Hits 8650 8673 +23
- Misses 2027 2061 +34 see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
Allows usage like
install_cmdstan --version=git:develop. Note: released versions will still always be selected over git versions by thecmdstan_path()function unless manually set or only one version exists.This is primarily for our own CI
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: