Skip to content

Allow git:TAG as a version in install_cmdstan#679

Merged
WardBrian merged 4 commits intodevelopfrom
install/allow-git-versions
Jul 22, 2023
Merged

Allow git:TAG as a version in install_cmdstan#679
WardBrian merged 4 commits intodevelopfrom
install/allow-git-versions

Conversation

@WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Allows usage like install_cmdstan --version=git:develop. Note: released versions will still always be selected over git versions by the cmdstan_path() function unless manually set or only one version exists.

This is primarily for our own CI

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian requested a review from mitzimorris July 21, 2023 19:30
Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and runs on my machine!

@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2023

Codecov Report

Merging #679 (df5c3a4) into develop (9b01be8) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #679      +/-   ##
===========================================
- Coverage    81.01%   80.79%   -0.22%     
===========================================
  Files           69       69              
  Lines        10677    10734      +57     
===========================================
+ Hits          8650     8673      +23     
- Misses        2027     2061      +34     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WardBrian WardBrian merged commit 730742a into develop Jul 22, 2023
@WardBrian WardBrian deleted the install/allow-git-versions branch July 22, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants