Skip to content

Accept np.floating and np.integer for arguments#663

Merged
WardBrian merged 1 commit intodevelopfrom
fix/647-accept-np-typed-args
Mar 24, 2023
Merged

Accept np.floating and np.integer for arguments#663
WardBrian merged 1 commit intodevelopfrom
fix/647-accept-np-typed-args

Conversation

@WardBrian
Copy link
Member

Submission Checklist

  • Run unit tests
  • Declare copyright holder and open-source license: see below

Summary

Closes #647. For our argument validation, we don't really care about the differences between int and np.int32 and friends, since we serialize to a string anyway.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@WardBrian WardBrian added bug Something isn't working code cleanup labels Mar 24, 2023
@WardBrian WardBrian requested a review from mitzimorris March 24, 2023 17:31
@WardBrian WardBrian marked this pull request as ready for review March 24, 2023 17:31
@codecov-commenter
Copy link

codecov-commenter commented Mar 24, 2023

Codecov Report

Merging #663 (20c57cc) into develop (087a765) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #663   +/-   ##
========================================
  Coverage    80.56%   80.56%           
========================================
  Files           69       69           
  Lines        10653    10653           
========================================
  Hits          8583     8583           
  Misses        2070     2070           

see 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@WardBrian WardBrian merged commit cd65084 into develop Mar 24, 2023
@WardBrian WardBrian deleted the fix/647-accept-np-typed-args branch March 24, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working code cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Seed argument doesn't accept np.int types

3 participants