Skip to content

Feature/1192 save metric json#1203

Merged
mitzimorris merged 20 commits intodevelopfrom
feature/1192-save-metric-json
Oct 25, 2023
Merged

Feature/1192 save metric json#1203
mitzimorris merged 20 commits intodevelopfrom
feature/1192-save-metric-json

Conversation

@mitzimorris
Copy link
Member

@mitzimorris mitzimorris commented Sep 18, 2023

Submisison Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

Add option to adaptive sampler args to save metric in separate JSON file with elements "stepsize" and "inv_metric"

Intended Effect:

Easy way to get pre-specified metric.

How to Verify:

Unit tests will pass once stan-dev/stan#3230 has been merged.

Side Effects:

N/A

Documentation:

Will add separately to docs repo.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@mitzimorris
Copy link
Member Author

this is ready for re-review

Copy link
Member

@WardBrian WardBrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really nice. A few comments but they're all minor now

@mitzimorris
Copy link
Member Author

one mo' time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants