receive header folding #104
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dearest Reviewer, I looked at issue stalwartlabs#81 and found that the CRLF was adding whitespace to the text during the integer parsing. I added a trim call to the error flow and try parsing again. I did this because it appears to be the exceptional case and normal flows will not take the cost of trim with every process. I can move the trim back out. I used the failing test that was provided. Thanks for your time Becker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dearest Reviewer,
I looked at issue #81 and found that the CRLF was adding whitespace to the text during the integer parsing. I added a trim call to the error flow and try parsing again. I did this because it appears to be the exceptional case and normal flows will not take the cost of trim with every process. I can move the trim back out.
I used the failing test that was provided.
Thanks for your time
Becker