Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow setting arbitrary resource constraints #255

Merged
merged 8 commits into from
Jul 6, 2023
Merged

Conversation

aslafy-z
Copy link
Collaborator

@aslafy-z aslafy-z commented Jul 5, 2023

This PR allows to request additional or non standard resources.
Also allows unsettings default resources from values using null.

@aslafy-z aslafy-z marked this pull request as ready for review July 5, 2023 10:11
@aslafy-z aslafy-z requested review from mustafaStakater, d3adb5, karl-johan-grahn and rasheedamir and removed request for mustafaStakater and d3adb5 July 5, 2023 10:11
d3adb5
d3adb5 previously approved these changes Jul 5, 2023
Copy link
Collaborator

@d3adb5 d3adb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I left a few suggestions.

application/templates/deployment.yaml Outdated Show resolved Hide resolved
application/templates/deployment.yaml Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@aslafy-z aslafy-z changed the title fix: allow unseting resources fix: allow setting arbitrary resources Jul 5, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: d3adb5 <me@d3adb5.net>
d3adb5
d3adb5 previously approved these changes Jul 5, 2023
Copy link
Collaborator

@d3adb5 d3adb5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment in an earlier thread. Otherwise, LGTM!

@aslafy-z aslafy-z changed the title fix: allow setting arbitrary resources fix: allow setting arbitrary resources constraints Jul 5, 2023
@aslafy-z aslafy-z changed the title fix: allow setting arbitrary resources constraints fix: allow setting arbitrary resource constraints Jul 5, 2023
@aslafy-z aslafy-z requested a review from d3adb5 July 5, 2023 22:09
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

@aslafy-z validation successful`

@aslafy-z aslafy-z merged commit 40fcf3b into master Jul 6, 2023
@aslafy-z aslafy-z deleted the aslafy-z-patch-1 branch July 6, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants