-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow setting arbitrary resource constraints #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslafy-z
requested review from
mustafaStakater,
d3adb5,
karl-johan-grahn and
rasheedamir
and removed request for
mustafaStakater and
d3adb5
July 5, 2023 10:11
d3adb5
previously approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I left a few suggestions.
aslafy-z
changed the title
fix: allow unseting resources
fix: allow setting arbitrary resources
Jul 5, 2023
aslafy-z
commented
Jul 5, 2023
Co-authored-by: d3adb5 <me@d3adb5.net>
d3adb5
previously approved these changes
Jul 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment in an earlier thread. Otherwise, LGTM!
aslafy-z
changed the title
fix: allow setting arbitrary resources
fix: allow setting arbitrary resources constraints
Jul 5, 2023
aslafy-z
changed the title
fix: allow setting arbitrary resources constraints
fix: allow setting arbitrary resource constraints
Jul 5, 2023
d3adb5
approved these changes
Jul 6, 2023
@aslafy-z validation successful` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to request additional or non standard resources.
Also allows unsettings default resources from values using
null
.