setup for reloader chart 3.0.0-beta.1 - #1198
Open
msafwankarim wants to merge 2 commits into
Open
Conversation
✅ Load Test Results (quick)✅ Load Test Results: ALL TESTS PASSED
3/3 passed (100%)
Artifacts: Download |
Felix-Stakater
approved these changes
Aug 17, 2026
✅ Load Test Results (quick)✅ Load Test Results: ALL TESTS PASSED
3/3 passed (100%)
Artifacts: Download |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Publish v2 under the existing
reloaderchart as 3.0.0-beta.xWhy
The v2 line was being published as a separate chart named
reloader-v2at version 2.0.0. That forks the chart identity: users would end up with two unrelated charts instakater/reloader, the chart version would no longer be comparable to the 2.2.x line already published, and every downstream reference (docs, RBAC names, e2e helpers, cosign, release tags) carries a name that only exists because v2 needed somewhere to live.This keeps one chart name,
reloader, and expresses the break the normal way instead: a major chart bump to 3.0.0, shipped as SemVer prereleases (3.0.0-beta.1) pointing at appVersionv2.0.0-beta.1. Helm skips prereleases by default, so existing v1 users onstakater/reloaderare untouched until they explicitly opt in with--devel.What changed
Chart identity:
Chart.yamlname back toreloader, version3.0.0-beta.1, appVersionv2.0.0-beta.1. Renders as<release>-reloader, so the e2e helm helpers and the RBAC name assertions in the chart tests follow.Prerelease plumbing, so a beta never presents itself as the latest thing:
.goreleaser.ymlgetsprerelease: auto, so av2.0.0-beta.1tag publishes as a GitHub prerelease rather than the repo's Latest releasev2Docker tag is only pushed for stable releases, sov2always resolves to the newest stable v2 buildchart-v3.0.0-beta.1tag are marked--prereleaseChart version gate:
helm search reponow passes--devel, otherwise the published prerelease is invisible to the gate and beta to beta bumps go unchecked. Also fixed the chart release workflow to usegithub.ref_name, sincegithub.refgavegh release createa fullrefs/tags/...ref and left the release title unstripped.One place to bump per release: the image tag was duplicated across
values.yaml,Chart.yamlappVersion, and two chart test assertions.image.tagnow defaults to.Chart.AppVersionwhen empty, so a release bump is a single line inChart.yaml. The digest path and explicit tag overrides are unchanged, and the chart tests assert the fallback rather than a literal version.Verification
helm lintclean,helm unittest35/35,go test ./test/e2e/utils/...passing. Rendered and checked all five image paths: default,global.imageRegistry, explicit tag, digest, and the e2e style override.Note for release ordering
Chart 3.0.0-beta.1 defaults to
ghcr.io/stakater/reloader:v2.0.0-beta.1, so the operator tag has to be pushed before this chart is published, otherwise a--develinstall lands in ImagePullBackOff.