Skip to content

setup for reloader chart 3.0.0-beta.1 - #1198

Open
msafwankarim wants to merge 2 commits into
v2from
revert/migrate-chart-to-3.0.0-beta.x
Open

setup for reloader chart 3.0.0-beta.1#1198
msafwankarim wants to merge 2 commits into
v2from
revert/migrate-chart-to-3.0.0-beta.x

Conversation

@msafwankarim

@msafwankarim msafwankarim commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Publish v2 under the existing reloader chart as 3.0.0-beta.x

Why

The v2 line was being published as a separate chart named reloader-v2 at version 2.0.0. That forks the chart identity: users would end up with two unrelated charts in stakater/reloader, the chart version would no longer be comparable to the 2.2.x line already published, and every downstream reference (docs, RBAC names, e2e helpers, cosign, release tags) carries a name that only exists because v2 needed somewhere to live.

This keeps one chart name, reloader, and expresses the break the normal way instead: a major chart bump to 3.0.0, shipped as SemVer prereleases (3.0.0-beta.1) pointing at appVersion v2.0.0-beta.1. Helm skips prereleases by default, so existing v1 users on stakater/reloader are untouched until they explicitly opt in with --devel.

helm repo update
helm install reloader stakater/reloader           # still Reloader v1, chart 2.2.x
helm install reloader stakater/reloader --devel   # Reloader v2 beta, chart 3.0.0-beta.1

What changed

Chart identity: Chart.yaml name back to reloader, version 3.0.0-beta.1, appVersion v2.0.0-beta.1. Renders as <release>-reloader, so the e2e helm helpers and the RBAC name assertions in the chart tests follow.

Prerelease plumbing, so a beta never presents itself as the latest thing:

  • .goreleaser.yml gets prerelease: auto, so a v2.0.0-beta.1 tag publishes as a GitHub prerelease rather than the repo's Latest release
  • the floating v2 Docker tag is only pushed for stable releases, so v2 always resolves to the newest stable v2 build
  • chart releases created from a chart-v3.0.0-beta.1 tag are marked --prerelease
  • the enterprise dispatch skips prereleases and chart releases, so betas do not kick off enterprise builds

Chart version gate: helm search repo now passes --devel, otherwise the published prerelease is invisible to the gate and beta to beta bumps go unchecked. Also fixed the chart release workflow to use github.ref_name, since github.ref gave gh release create a full refs/tags/... ref and left the release title unstripped.

One place to bump per release: the image tag was duplicated across values.yaml, Chart.yaml appVersion, and two chart test assertions. image.tag now defaults to .Chart.AppVersion when empty, so a release bump is a single line in Chart.yaml. The digest path and explicit tag overrides are unchanged, and the chart tests assert the fallback rather than a literal version.

Verification

helm lint clean, helm unittest 35/35, go test ./test/e2e/utils/... passing. Rendered and checked all five image paths: default, global.imageRegistry, explicit tag, digest, and the e2e style override.

Note for release ordering

Chart 3.0.0-beta.1 defaults to ghcr.io/stakater/reloader:v2.0.0-beta.1, so the operator tag has to be pushed before this chart is published, otherwise a --devel install lands in ImagePullBackOff.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

✅ Load Test Results (quick)

✅ Load Test Results: ALL TESTS PASSED

🚀 Quick Test (S1, S4, S6) — Use /loadtest for full suite

3/3 passed (100%)

Scenario Description Actions Errors
S1 S1: 142 burst updates, each triggers 1 dep... 141/142 0
S4 S4: 143 no-op updates, all should be skipped 0 0
S6 S6: Restart test - 142 updates during restart 145 0

📦 Download detailed results


Artifacts: Download

@github-actions

Copy link
Copy Markdown

✅ Load Test Results (quick)

✅ Load Test Results: ALL TESTS PASSED

🚀 Quick Test (S1, S4, S6) — Use /loadtest for full suite

3/3 passed (100%)

Scenario Description Actions Errors
S1 S1: 143 burst updates, each triggers 1 dep... 142/143 0
S4 S4: 0 no-op updates, all should be skipped 0 0
S6 S6: Restart test - 142 updates during restart 137 0

📦 Download detailed results


Artifacts: Download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants