Skip to content

feat(chart): support runtimeClassName and schedulerName in Reloader deployment - #1181

Merged
msafwankarim merged 2 commits into
stakater:masterfrom
somaz94:feat/deployment-runtimeclassname-schedulername
Aug 10, 2026
Merged

feat(chart): support runtimeClassName and schedulerName in Reloader deployment#1181
msafwankarim merged 2 commits into
stakater:masterfrom
somaz94:feat/deployment-runtimeclassname-schedulername

Conversation

@somaz94

@somaz94 somaz94 commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

Adds runtimeClassName and schedulerName support to the Reloader deployment pod spec, matching the existing scheduling knobs (nodeSelector, affinity, tolerations, topologySpreadConstraints, priorityClassName). Both default to empty and render only when set, so behavior is unchanged for existing users.

Validation:

  • helm unittest: 13 passed (9 existing + 4 new, covering set + default-omitted for both fields)
  • helm template: both fields absent by default, rendered correctly when set
  • helm lint: 0 failed
  • Chart.yaml bumped 2.2.14 -> 2.2.15

@somaz94
somaz94 marked this pull request as ready for review July 20, 2026 08:25
msafwankarim
msafwankarim previously approved these changes Aug 4, 2026
@somaz94

somaz94 commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

Merged master in to clear the conflict — this is mergeable again.

@msafwankarim sorry, this dismissed your approval: the repo re-requests review on push, so your 2026-08-04 sign-off is gone even though nothing in the feature changed. The only alternative was leaving it conflicted and unmergeable, so I took the trade. The feature diff is byte-identical to what you approved — everything below is merge resolution only.

Two things worth calling out in the resolution, since both would have been silent regressions:

  • appVersion conflicted and I took master's v1.4.20. My branch still carried v1.4.19 from when it was opened, so resolving in favour of "mine" would have quietly rolled the app version back inside Chart.yaml.
  • version was 2.2.15 on both sides — master released 2.2.15 in the meantime, so my original bump was overtaken and would have collided. Re-bumped to 2.2.16.

Net effect on Chart.yaml is now a single line: 2.2.152.2.16. Nothing else in the merge touched the feature.

helm lint clean and helm unittest green (45 tests, 2 suites) against the merged tree. Nothing else owed from my side.

Two side effects of the push worth naming, both outside my control: the chart workflow for this head sha is sitting at action_required so CI hasn't started (the check list reads empty rather than failing), and the approval above was auto-dismissed. Both need a maintainer click — happy to do anything else that helps.

@msafwankarim
msafwankarim merged commit 6d85856 into stakater:master Aug 10, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants