-
Notifications
You must be signed in to change notification settings - Fork 715
test: fourth set of consensus tests for CheckErrorKind during contract analysis
#6703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
test: fourth set of consensus tests for CheckErrorKind during contract analysis
#6703
Conversation
| } | ||
|
|
||
| /// StaticCheckErrorKind: [`StaticCheckErrorKind::IllegalOrUnknownFunctionApplication`] | ||
| /// Caused by: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha I know its redundant considering how explicit the static check error kind name is, but it irks my soul that these Caused by's are empty :P (Note: you should not fill them out. Its pointless to do so lol )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually do have to fill them out, or I'll not be able to sleep properly! I just forgot, thanks for pointing out!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in d7345b4 (alonside resolving merge conflicts)
jacinta-stacks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (70.57%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## develop #6703 +/- ##
===========================================
- Coverage 80.03% 70.57% -9.46%
===========================================
Files 577 577
Lines 357651 357750 +99
===========================================
- Hits 286235 252477 -33758
- Misses 71416 105273 +33857
... and 333 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Description
Fourth of 7 PRs that will supersede #6661
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/rpc/openapi.yamlandrpc-endpoints.mdfor v2 endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo